pre-release updates #42
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
|
Resolves #26 |
There was a problem hiding this comment.
We shouldn't leave commented out code.
solpolpy/polarizers.py
Outdated
| @@ -19,6 +19,11 @@ def npol_to_mzp(input_cube): | |||
| in_list = list(input_cube) | |||
| conv_fact = (np.pi * u.radian) / (180 * u.degree) | |||
|
|
|||
| if input_cube['angle_1'].meta['OBSRVTRY'] == 'STEREO_B': | |||
| offset_angle = -18 * u.degree * conv_fact # STEREOB | |||
There was a problem hiding this comment.
These factors (-18, 45.8) are a bit cryptic to me. We should document them somehow more clearly. Where do they come from? What do they do?
There was a problem hiding this comment.
These are obtained from Thompson (2015)
There was a problem hiding this comment.
Please note this in the source code and the docstring fro this function.
solpolpy/constants.py
Outdated
There was a problem hiding this comment.
Can you elaborate on this change for me? fourpol versus npol.
There was a problem hiding this comment.
fourpol is for 0, 45, 90, 135 input angles
npol is for M', Z', P' which are separated by 60 degree but deviate from the standard MZP.
There was a problem hiding this comment.
I noticed alpha.py has little test coverage. Please make sure it's tested.
The add_alpha function in core.py needs to be tested. It also needs #35 resolved.
Your fourpol_to_stokes method in polarizers.py is untested.
We could also improve the documentation everywhere, just docstrings. Don't worry about generating the docs website. We'll take care of that in another issue.
| # return np.fliplr(np.arctan2(yy, xx))*u.radian | ||
| return np.flipud(np.rot90(np.fliplr(np.arctan2(yy, xx) + np.pi), k=1))* u.radian | ||
|
|
||
| return np.rot90(np.fliplr(np.arctan2(yy, xx)+np.pi), k=1)*u.radian |
There was a problem hiding this comment.
This is not covered by tests. I notice most of the alpha.py file isn't. Let's write some tests and also make proper docstrings.
| data_out.append(("angle_3", NDCube(np.array([1]), wcs=wcs, meta={'POLAR': -60}))) | ||
| data_out.append(("angle_1", NDCube(np.array([1]), wcs=wcs, meta={'POLAR': 60, 'OBSRVTRY': 'LASCO'}))) | ||
| data_out.append(("angle_2", NDCube(np.array([1]), wcs=wcs, meta={'POLAR': 0, 'OBSRVTRY': 'LASCO'}))) | ||
| data_out.append(("angle_3", NDCube(np.array([1]), wcs=wcs, meta={'POLAR': -60, 'OBSRVTRY': 'LASCO'}))) | ||
| # data_out.append(("alpha", NDCube(np.array([0])*u.radian, wcs=wcs))) |
There was a problem hiding this comment.
Please remove the commented out line.
tests/test_core.py
Outdated
| # """test pB from single angle fn in core""" | ||
| # | ||
| # output=pB_from_single_angle(B, B_theta, theta, alpha) | ||
| # np.testing.assert_allclose(output, expected, rtol=1e-05) No newline at end of file | ||
| # np.testing.assert_allclose(output, expected, rtol=1e-05) |
This patch adds @s0larish 's new contributions
-- @jmbhughes